[xen-tools-dev] Make tests pass

Stéphane Jourdois sjourdois at gmail.com
Sun Jul 11 15:38:41 CEST 2010


Hi,

Please find here some patches to make tests pass.
Apply those on top on git and my previous patches.

Some patches are not trivial but all should be simple enough to test.

Enjoy,
Stéphane (kwisatz) Jourdois

Stéphane Jourdois (28):
      Skip Xen::Tools tests
      Remove hyphen in options.
      Rename genpass-len to genpass_len to match default config.
      Update indentation for options.
      Strip single quotes as well as double quotes.
      Use same conventions for options as other scripts.
      Use long options for xt-guess-suite-and-mirror
      Disable other getty lines as debian does.
      Use intrepid sed script for inittab
      Use hvc0 instead of tty1.
      Test file before modifying
      Replace tabs with spaces
      Remove done_testing call.
      Typo
      Remove trailing spaces
      Print file
      Replace single quotes by doubles quotes in scripts
      Print file
      Remove trailing whitespace
      Typo
      Remove trailing space
      Use rmtree not rmdir
      Test variable before use
      Get extension from command line and not from environment
      Export partitions in test and use xvda as default
      Remove tabs in previous patch
      Use skip_all rather than SKIP block
      All tests now pass, remove TODO

diffstat follows:

 TODO                                    |    9 ----
 bin/xen-create-image                    |   45 +++++++++++-----------
 bin/xen-delete-image                    |    5 +-
 bin/xen-list-images                     |    4 +-
 bin/xen-update-image                    |   26 +++++++------
 bin/xt-create-xen-config                |    5 +-
 bin/xt-customize-image                  |   12 +++---
 bin/xt-guess-suite-and-mirror           |   27 +++++++------
 bin/xt-install-image                    |   32 ++++++++--------
 etc/xen-tools.conf                      |    4 +-
 hooks/centos-4/40-setup-networking      |   10 ++--
 hooks/centos-5/40-setup-networking      |   10 ++--
 hooks/common.sh                         |   18 ++++----
 hooks/dapper/40-setup-networking        |   10 ++--
 hooks/dapper/50-setup-hostname          |   12 +++---
 hooks/dapper/70-install-ssh             |    4 +-
 hooks/debian/15-disable-hwclock         |    2 +-
 hooks/debian/20-setup-apt               |    2 +-
 hooks/debian/40-setup-networking        |   10 ++--
 hooks/debian/50-setup-hostname          |   12 +++---
 hooks/debian/55-create-dev              |    4 +-
 hooks/debian/70-install-ssh             |    4 +-
 hooks/debian/80-install-kernel          |   64 +++++++++++++++---------------
 hooks/debian/95-configure-locales       |    2 +-
 hooks/edgy/40-setup-networking          |   10 ++--
 hooks/edgy/50-setup-hostname            |   12 +++---
 hooks/edgy/70-install-ssh               |    4 +-
 hooks/edgy/80-install-kernel            |   32 ++++++++--------
 hooks/fedora-core-6/40-setup-networking |   10 ++--
 hooks/gentoo/40-setup-networking        |   10 ++--
 hooks/intrepid/30-disable-gettys        |   10 +++--
 hooks/intrepid/40-setup-networking      |   10 ++--
 hooks/intrepid/50-setup-hostname        |   12 +++---
 hooks/intrepid/70-install-ssh           |    4 +-
 hooks/intrepid/80-install-kernel        |   16 ++++----
 hooks/karmic/30-disable-gettys          |   10 +++--
 hooks/karmic/40-setup-networking        |   10 ++--
 hooks/karmic/50-setup-hostname          |   12 +++---
 hooks/karmic/70-install-ssh             |    4 +-
 t/getopt.t                              |    8 ++--
 t/hook-inittab.t                        |    2 +-
 t/perl-syntax.t                         |    4 +-
 t/pod-check.t                           |    2 +-
 t/portable-shell.t                      |    6 +-
 t/quoted-strings.t                      |    2 +-
 t/test-trailing-whitespace.t            |    2 +-
 t/xen-delete-image.t                    |    2 +-
 t/xen-tools-log.t                       |    6 +--
 t/xen-tools.t                           |    3 +-
 t/xt-create-xen-config.t                |   29 ++++++++++----
 50 files changed, 288 insertions(+), 277 deletions(-)



More information about the xen-tools-dev mailing list