[xen-tools-dev] [PATCH] Use rmtree not rmdir

Stéphane Jourdois sjourdois at gmail.com
Sun Jul 11 15:39:03 CEST 2010


rmdir does not remove dir when not empty. Use rmtree for that.
makes t/xen-delete-image test pass.
---
 bin/xen-delete-image |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/bin/xen-delete-image b/bin/xen-delete-image
index e7d40db..f0e99f7 100755
--- a/bin/xen-delete-image
+++ b/bin/xen-delete-image
@@ -156,6 +156,7 @@ use strict;
 use English;
 use Getopt::Long;
 use Pod::Usage;
+use File::Path;
 
 
 #
@@ -517,7 +518,7 @@ sub deleteXenImage
                 print "Would delete: $prefix$hostname\n";
             } else {
                 print "Removing: " . $prefix . $hostname . "\n";
-                rmdir( $prefix . $hostname );
+                rmtree( $prefix . $hostname );
             }
         }
     }
-- 
1.5.6.5



More information about the xen-tools-dev mailing list