[xen-tools-dev] [PATCH] Use skip_all rather than SKIP block

Stéphane Jourdois sjourdois at gmail.com
Sun Jul 11 15:39:08 CEST 2010


This makes prove t output less verbose
---
 t/xen-tools-log.t |   15 +++++----------
 t/xen-tools.t     |   10 +++-------
 2 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/t/xen-tools-log.t b/t/xen-tools-log.t
index d2ad5f2..b4c594e 100755
--- a/t/xen-tools-log.t
+++ b/t/xen-tools-log.t
@@ -2,19 +2,14 @@
 
 use strict;
 use warnings;
-use Test::More tests => 1;
+use Test::More tests => 1, skip_all => 'Xen::Tools::Log is not used for now';
 use File::Temp;
 
 use Xen::Tools::Log;
 
-SKIP: {
-    skip "Xen::Tools::Log is not used for now", 1;
+my $dir = File::Temp::tempdir( CLEANUP => 1 );
 
-    my $dir = File::Temp::tempdir( CLEANUP => 1 );
+my $xtl = Xen::Tools::Log->new( hostname => 'xen-tools-log-test',
+                                logpath  => $dir );
 
-    my $xtl = Xen::Tools::Log->new( hostname => 'xen-tools-log-test',
-                    logpath  => $dir,
-                      );
-
-    ok( $xtl->isa('Xen::Tools::Log') );
-}
+ok( $xtl->isa('Xen::Tools::Log') );
diff --git a/t/xen-tools.t b/t/xen-tools.t
index 5c17341..9fa753d 100755
--- a/t/xen-tools.t
+++ b/t/xen-tools.t
@@ -6,13 +6,9 @@
 
 use strict;
 use warnings;
-use Test::More tests => 1;
+use Test::More tests => 1, skip_all => 'Xen::Tools is not used for now';
 
 use Xen::Tools;
 
-SKIP: {
-    skip "Xen::Tools is not used for now", 1;    
-
-    my $xt = Xen::Tools->new( hostname => 'xen-tools-test' );
-    ok( $xt->isa('Xen::Tools') );
-}
+my $xt = Xen::Tools->new( hostname => 'xen-tools-test' );
+ok( $xt->isa('Xen::Tools') );
-- 
1.5.6.5



More information about the xen-tools-dev mailing list