[xen-tools-dev] [PATCH] Add new nameserver config option

[Axel Beckert]

On Sat, Jul 10, 2010 at 12:52:17PM +0200, Stéphane Jourdois wrote:
> This optional config value is used in hooks to create domU resolv.conf.
> If unset, domU's resolv.conf is created by the guest distrib install.
[...]
> +   --nameserver=123.456.789.ABC
> +                Setup the nameserver of the machine, multiple nameservers
> +		are allowed.
> +

I added some hints on the needed delimiter between multiple nameservers.

> +    if [ '*' != "*$nameserver" ]; then
             ^      ^

These asterisks are not necessary. I even find them confusing because
they have a special meaning in shell scripts if unquoted (would
have used "x" instead formerly), so I just removed them.

> +	rm -f ${prefix}/etc/resolv.conf.old
> +	for ns in $nameserver; do 
                                 ^

Removed the trailing whitespace here, too.

Unfortunately this conflicts with your later whitespace/tabs commit.
:-/

Will fix that later today.

More on that discusssion at the appropriate patch.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)