[xen-tools-dev] RFC : arguments validation

[Dmitry Nedospasov]

> 2010-07-18  77eeeb2  Stéphane Jourdois (stephane at jourdois.fr)
> Add a gitignore coherency test

I didn't quite get what this one is doing, could you explain?

> 2010-07-18  77eeeb2  Stéphane Jourdois (stephane at jourdois.fr)
> Add a gitignore coherency test
> --- a/t/shell-syntax.t
> +++ b/t/shell-syntax.t
> @@ -34,26 +34,25 @@ sub checkFile
>      # We don't care about directories
>      return if ( ! -f $file );
> 
> -    # Finally mercurial files are fine.
> -    return if ( $file =~ /\.(hg|git)\// );
> +    # Finally mercurial/git files are fine.
> +    return if ( $file =~ /^\.\/\.(hg|git)\// );
> 
>      # See if it is a shell script.
>      my $isShell = 0;

Is there any reason why we should still be using hg?

> 2010-07-18  8219a18  Stéphane Jourdois (stephane at jourdois.fr)
> Debootstrap only exists on Debian and Ubuntu

I install debootstrap for xen-tools on my CentOS boxes. I personally
think that debootstrap is a requirement, since it is the only thing
reliably installing right now, but i see your point. We should try to
keep things modular.

> 2010-07-18  4e756da  Stéphane Jourdois (stephane at jourdois.fr)
> Use Dom0's resolv.conf unless nameserver is set.

Nice one! I like it :)

> 2010-07-18  8159a7b  Stéphane Jourdois (stephane at jourdois.fr)
> Validate option arguments

And i really like this one too, well documented as well!


@Axel: You might want to take a look at the tests, since you're more
experienced with them.

Everything else looked good as well.

D.

-- 
Dmitry Nedospasov <dmitry at nedos.net>
http://nedos.net - Twitter: @nedos - GPG: 0x5EED4EED