[xen-tools-dev] RFC : arguments validation

[Stéphane Jourdois]

Hi,

Le 18/07/2010 17:57, Dmitry Nedospasov a écrit :
>> 2010-07-18  77eeeb2  Stéphane Jourdois (stephane at jourdois.fr)
>> Add a gitignore coherency test
>
> I didn't quite get what this one is doing, could you explain?

Of course ! This test tests two things.

1) if you ignore some files (in .gitignore) and they are in tree 
currently, then probably you are mistaken in .gitignore, or you should 
remove some files from git tree.
For example, if adding '*.sh' in .gitignore, the test will bail that 
there are two files in the tree that will be ignored from now, and that 
is probably bad.

2) if you have files not in tree nor in .gitignore (shown by 'git 
status') as untracked files, you should probably do one of the following 
: add them to the tree so they are uploaded, or add them to gitignore so 
that you don't get untracked files in your git status and not be annoyed 
by warnings later.

I'm sorry that my comments in the test file weren't clear enough.


> Is there any reason why we should still be using hg?

Absolutely no idea, but that is not my decision to make :-D


>> 2010-07-18  8219a18  Stéphane Jourdois (stephane at jourdois.fr)
>> Debootstrap only exists on Debian and Ubuntu
>
> I install debootstrap for xen-tools on my CentOS boxes. I personally
> think that debootstrap is a requirement, since it is the only thing
> reliably installing right now, but i see your point. We should try to
> keep things modular.

debootstrap doesn't exists on ArchLinux, which I use on my desktop. My 
servers are under debian.
Note that tests are here for developers, not for users. Debootstrap is 
not needed for developers (as in perl editing), it is needed for users 
(as in actually running xen-create-image), and its presence is checked 
in xt-install-image as it should.


>> 2010-07-18  4e756da  Stéphane Jourdois (stephane at jourdois.fr)
>> Use Dom0's resolv.conf unless nameserver is set.
>
> Nice one! I like it :)

Haha, you asked for it, so I indeed hope you like it ;-)


>> 2010-07-18  8159a7b  Stéphane Jourdois (stephane at jourdois.fr)
>> Validate option arguments
>
> And i really like this one too, well documented as well!

Thanks :)


> Everything else looked good as well.

And again, thanks for your fast review !

Stéphane.

-- 
  ///  Stephane Jourdois     /"\  ASCII RIBBON CAMPAIGN \\\
(((    Consultant securite  \ /    AGAINST HTML MAIL    )))
  \\\   157 Bd Davout         X                         ///
   \\\  75020  Paris         / \    +33 6 8643 3085    ///