[xen-tools-dev] Bug#610457: bug: xen-tools - apt-setup for lucid ignores --mirror

[Axel Beckert]

Hi Alex,

Alex Tomlins wrote:
>>> I've implemented this here:
>>> https://gitorious.org/~alext/xen-tools/alext-xen-tools/commits/apt_proxy
>> Thanks!
>>
>>  From a first glance it looks good and I'll probably include your
>> patches. I'd though change two things:
>>
>> * Change the option's name from apt_proxy to apt-proxy.
> Makes sense.  I wasn't sure which way to go as the existing options seem  
> to use a mixture.

Well, yeah, historically grown. But I'd prefer to not have underscores
in long options. Maybe we'll once change all of them to dashes, but
supoort underscores for backwards-compatibility.

>> * Instead of prepending the environment variable to some command, I'd
>>    prefer to use $ENV{http_proxy}, etc.
> I was mostly being cautious there to make sure it didn't effect anything  
> else (as the proxy is typically an apt-cacher type proxy, and not a  
> general http proxy).

Yeah, and for using $ENV{http_proxy} the opposite was the reason. I
thought it would be good if then anything uses the proxy in general.

But maybe it would be also good to distinguish between 

1) proxy setting for the installation (which happens on the Dom0)
2) proxy setting for the DomU (after installation)
3) all other things (if there are any)

> Having had a closer look, I can't see it effecting  
> anything else, so I'll push that change up as well

Your arguments made think a little bit more about this issue. Not sure
though, what's the best way to handle it.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5