[xen-tools-dev] Bug in the password promt in master

[Axel Beckert]

Hi Joan,

On Fri, Oct 25, 2013 at 11:03:51AM +0200, Joan wrote:
> >             my $tryagain = 1;
> >>             my $term = Term::ReadLine->new('Password change failed');
> >>             while ($tryagain) {
> >>                 my $rc = system("chroot $MOUNT_POINT /usr/bin/passwd");
> >>                 if ($rc >> 8) {
> >>                     $tryagain = $term->ask_yn(
> >>                         prompt => 'Do you want to try to change the
> >> password again??',
> >>                         default => 'y',
> >>                     );
> >>                 } else {
> >>                     $tryagain=0;
> >>                 }
> >>             }
[...]
> I created a merge request with the fixed code here:
> https://gitorious.org/xen-tools/xen-tools/merge_requests/7

Thanks for the pull request. I was confused because the above looked
like a diff but wasn't a diff fixing the issue.

And thanks for spotting this. Seems as if I haven't checked all cases
when implementing that. :-/

Both merge requests will be included soon.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)