<div dir="ltr"><div>Since it involved changing only a line I tried to avoid having to create the fork, the branch, push request stuff, but it's easy this way indeed.</div><div>I'll look into more changes asap</div>
<div> </div><div>Regards, </div><div><br></div><div>Joan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/10/25 Axel Beckert <span dir="ltr"><<a href="mailto:abe@deuxchevaux.org" target="_blank">abe@deuxchevaux.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Joan,<br>
<div class="im"><br>
On Fri, Oct 25, 2013 at 11:03:51AM +0200, Joan wrote:<br>
> >             my $tryagain = 1;<br>
> >>             my $term = Term::ReadLine->new('Password change failed');<br>
> >>             while ($tryagain) {<br>
> >>                 my $rc = system("chroot $MOUNT_POINT /usr/bin/passwd");<br>
> >>                 if ($rc >> 8) {<br>
> >>                     $tryagain = $term->ask_yn(<br>
> >>                         prompt => 'Do you want to try to change the<br>
> >> password again??',<br>
> >>                         default => 'y',<br>
> >>                     );<br>
> >>                 } else {<br>
> >>                     $tryagain=0;<br>
> >>                 }<br>
> >>             }<br>
</div>[...]<br>
<div class="im">> I created a merge request with the fixed code here:<br>
> <a href="https://gitorious.org/xen-tools/xen-tools/merge_requests/7" target="_blank">https://gitorious.org/xen-tools/xen-tools/merge_requests/7</a><br>
<br>
</div>Thanks for the pull request. I was confused because the above looked<br>
like a diff but wasn't a diff fixing the issue.<br>
<br>
And thanks for spotting this. Seems as if I haven't checked all cases<br>
when implementing that. :-/<br>
<br>
Both merge requests will be included soon.<br>
<br>
                Kind regards, Axel<br>
<span class="HOEnZb"><font color="#888888">--<br>
/~\  Plain Text Ribbon Campaign                   | Axel Beckert<br>
\ /  Say No to HTML in E-Mail and News            | <a href="mailto:abe@deuxchevaux.org">abe@deuxchevaux.org</a>  (Mail)<br>
 X   See <a href="http://www.asciiribbon.org/" target="_blank">http://www.asciiribbon.org/</a>              | <a href="mailto:abe@noone.org">abe@noone.org</a> (Mail+Jabber)<br>
/ \  I love long mails: <a href="http://email.is-not-s.ms/" target="_blank">http://email.is-not-s.ms/</a> | <a href="http://noone.org/abe/" target="_blank">http://noone.org/abe/</a> (Web)<br>
_______________________________________________<br>
xen-tools-dev mailing list<br>
<a href="mailto:xen-tools-dev@xen-tools.org">xen-tools-dev@xen-tools.org</a><br>
<a href="https://xen-tools.org/mailman/listinfo/xen-tools-dev" target="_blank">https://xen-tools.org/mailman/listinfo/xen-tools-dev</a><br>
</font></span></blockquote></div><br></div>