[xen-tools] Re: Outstanding bugs/requests for 3.0?

[Ward Vandewege]

On Fri, Dec 01, 2006 at 12:56:18PM +0000, Steve Kemp wrote:
> On Fri, Dec 01, 2006 at 07:45:38AM -0500, Ward Vandewege wrote:
> 
> > Effectively, this means that the --memory option given to xen-create-image
> > needs to be put in megabytes, always, and any modifier is ignored (unlike
> > for --size and --swap).
> 
>   Good catch.  This looks like a good change:
> 
>     #
>     #  The memory size:  Convert Gb -> Mb.
>     #
>     if ( $EMV{'memory'} =~ /^(\d+)Gb*$/i )
>     {
>         $ENV{'memory'} = $1 * 1024;
>     }
> 
>     #
>     #  Remove any trailing Mb.
>     #
>     if ( $ENV{'memory'} =~ /^(\d+)Mb*$/i )
>     {
>         $ENV{'memory'} = $1;
>     }
> 
>   I'll commit shortly.

Can you make the 'b' optional? I think the lvm tools take 'M' or 'G' without
any b.

Thanks,
Ward.

-- 
Pong.be         -(  "Creativity can be a social contribution, but only in  )-
Virtual hosting -(  so far as society is free to use the results." -- RMS  )-
http://pong.be  -(                                                         )-
GnuPG public key: http://gpg.dtype.org