[xen-tools] Re: More changes

[C.J. Adams-Collier]

On 8/30/07, Steve Kemp <steve at steve.org.uk> wrote:
> On Thu Aug 30, 2007 at 12:09:04 -0700, C.J. Adams-Collier wrote:
>
> > I fixed all of the sev5 errors.  Here's a patch.  The unit tests pass
> > for create-xen-image, so I assume the fix is fine.  Also, I've
> > attached a ChangeLog file using the standard format.  Please add this
> > to the root of the project and add change notes on each submit.
>
>   Thanks for the fixes.  Some look sane, some do not.  I will
>  reply to the list tomorrow with a critique, but I can give it
>  to you personally if you prefer.

Either way.  I am more than happy to make the changes.  It's your
code, after all :)

>   The ChangeLog file, unfortunately, I will not accept like that
>  although I will try to replicate it.  (Mostly on technology
>  groups; as you're familiar with the Makefile you'll see that
>  the ChangeLog file is created by examining CVS commit messages
>  and I'm not keen on throwing that away just yet.)

Ah.  I did not see that there was a dynamically generated ChangeLog.
I can add my entries to the CVS commit, in this case.

> > I'm also working on re-factoring a lot of this code into a new
> > Xen::Tools CPAN module.  I'd be happy to host it in this repository,
> > but it looks like there's no root in which related projects live.
>
>   I have to say that I object to this work, in its current form,
>  on two main grounds:
>
>     a)  There is no mention of my name, my project, or
>        my website, in your current download.

I apologize for forgetting to do this.  I intended to, but it slipped
my mind.  I have added your name and the links from xen-tools' README
to the Xen::Tools README.  I have also added a file called
AUTHORS.xen-tools to the root of the package containing the contents
of AUTHORS from xen-tools

>     b)  I like the idea of a collection of library functions
>        but I don't think that your current split is as good
>        as it could be.

I'm happy to take recommendations.  Also, I mentioned hosting the
package on your repository site if you felt that it would be a good
idea.  In this case, you would be the de facto administrator of the
code, and you could make any changes you saw fit.  I personally prefer
subversion, but it's not a big enough deal to make a fuss over.

>     c)  I strongly object to the naming of the module(s).

I await your recommendations with breath abated.

> > It's certainly not done yet, but you can see a bit of what I'm
> > thinking.  I'm starting with xen-create-image and moving the subs into
> > the Xen::Tools package.
>
>   I'm going to have to say that I strongly disapprove and object
>  to you releasing any code with such a similar name to my project,
>  especially when you're not (currently) offering any credit to
>  myself or any of the previous contributors.

I've uploaded the new tarball in the same location as the old.  Again,
I apologize for missing this before.

>   I'm pretty certain I couldn't enforce that, and if I could I wouldn't
>  want to start going down that route, but as a matter of courtesy
>  I'd urge you to think of a different name.

If you insist, I will rename the module.  I had, however, hoped that
xen-tools would one day officialy use Xen::Tools to library-ize its
functionality.  If this were to happen, I would expect that the module
name would be appropriate.  But again, I will make the effort to
rename the modules if you don't forsee this happening.

> > Xen::Tools depends only on perl modules packaged for etch.
>
>   :)
>
> > xt-create-xen-config is totally horked in CVS.  Unit tests are failing.
>
>   Known bug.  The new partition handling code has broken it, and
>  it will be fixed prior to the next release.
>
> Steve

Thank you for your feedback!

C.J.

-- 
moo.