[xen-tools] Re: More changes

[Steve Kemp]

On Sat Sep 01, 2007 at 23:12:55 -0700, C.J. Adams-Collier wrote:
> On 9/1/07, Steve Kemp <steve at steve.org.uk> wrote:

> I haven't played much with git, hg or bzr, but they all seem
> promising.  Having the backing of the folks from the lkml is likely a
> good indication that git is the best of these.

  Yeah I've not used it for distributed work before, for that I 
 use darcs a fair bit at work.

> I merged the code under Xen-Tools-0.1/lib/ with implementation and
> unit tests (Xen/Tools.pm and Xen/Tools/Log.pm) into xen-tools this
> afternoon, but wasn't able to get 'make test' to run flawlessly.  When
> things look clean, I'll submit a diff and a ChangeLog entry.

  OK.

> The main change that you may have issue with, Steve, is that I
> re-named 'Makefile' to 'makefile' in order to keep Makefile.PL from
> overwriting it.

  I don't see why this is necessary .. It seems that you're
 agreed with my point of merging the library code into the
 xen tools repository / directory.

  If that is the case then we don't *need* to have Makefile.pl,
 we can do the installation with the Makefile.

  ie. I don't see that we need:

    Make -f makefile install   (install docs + bin/*)
    perl Makefile.pl           (generate Makefile for module)
    make install               (install lib/*)

> Steve, you mentioned earlier that you could not see a use case for
> external programs linking to libraries from xen-tools.  This is
> exactly what I intend to do and the reason for my interest and
> contributions.

  I think I said it seemed unlikely; but I'd also guess that
 unless you add in some feedback API you're not gaining much
 with that approach:

    exec( libperl ...  )
   vs.
    exec ( xen-create...)

> Steve, do you mind me mentioning this work in my blog?

  Not at all :)

> You had
> mentioned before that you were concerned that I was not giving credit
> where credit is due, and I would not want to reproduce that feeling of
> ill will.

  You won't.  As far as I'm converned when you uploaded a fixed tarball
 that was solved.

> Let me say for the record that I feel that this codebase is an
> excellent piece of work, and that I appreciate all of the hard work
> that Steve and the team has contributed.

  Thanks a lot from all of us.  (Just ignore the bad code, which is
 mostly mine :)

Steve
-- 
Debian GNU/Linux System Administration
http://www.debian-administration.org/