[xen-tools-discuss] Roles to be executed after config file is written?

[Axel Beckert]

Hi Pieter,

I'm currently preparing a new xen-tools release and checking which
patches I haven't incorporated and which bug I haven't tried to fix
yet.

On Fri, Aug 26, 2011 at 03:02:32PM +0200, Pieter Barrezeele wrote:
> In attachment you'll find some patches that apply to the 4.2 version
> of Xen-tools.

Thanks!

> - image-dev.patch: when choosing image-dev as destination device,
>   xen-tools should not verify the availability of lvm tools

Granted. Applied. Thanks!

> - finalrole.patch: As the code is now: roles are implemented before
>   the creation of the Xen config file. I needed a script to be run
>   using that config file (git repo stuff). There might be a
>   requirement having roles implemented before the xen config file. I
>   therefore added a --finalrole config setting that executes after
>   the Xen config file creation.

Nice idea! Applied. Thanks!

> - dontformat.patch: I tend to create my filesystems manually. I therefore implemented a --dontformat switch which does just what it says.

Looks simple and fine. Applied.

> - extension.patch: currently, xt-create-xen-config assumes a default
>   value for the 'extension' configuration setting, which is not
>   unsettable: one cannot have an empty extension. I therefore
>   emptied the default value in xt-create-xen-config. Wouldn't it be
>   better to have the defaults in a provided config file instead of
>   the code?

You hit one of my own itches. I'm annoyed that one of our commits in
the last two years broke this. It worked with 3.9 in Lenny.

I'm though reluctant to change the default value. OTOH if I change the
default in xt-create-xen-config and set the old default in
xen-tools.conf, that could work. Will think about it.

> I hope you can use (and incorporate) these patches. :-)

Indeed, thanks again!

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)