[xen-tools-discuss] installDebianPackage + --no-install-recommends == subtle issues (w/ custom roles)

[Axel Beckert]

Hi Eric,

On Wed, Nov 20, 2013 at 02:20:06PM -0600, Eric Engstrom wrote:
> I'm sure there was some good thought behind the commit so that
> recommended packages are no longer installed by installDebianPackage()
> in hooks/common.sh. (see details below)
> 
> However, it took me a good while to realize this was the reason my
> custom role file was not installing all the packages I expected.
> 
> Specifically in my case, I noted this first with the debian package
> `logcheck`, which recommends `logcheck-database`, but I really expected
> and wanted the latter too.  Of course, my workaround for now is to
> _explicitly_ install some recommended packages like that.  I haven't yet
> gone through all my custom role installed packages, but I'm sure I'll
> find at least one more place where I want the recommended packages.

Hrm, ok. I see the impact is bigger than I expected.

What I can offer is to add a function named
installDebianPackageAndRecommends or similar in hooks/common.sh so
that it's easier for those who relied on it to convert their roles or
hooks.

Would that help you?

> Anyone care to expand on the reasons for the change?

Yeah.

General:

* Adding packages makes more sense than having to remove packages.

* In average it's faster. If you have one package where you want the
  recommandations, too, and one where you don't want them, previously
  you had to install them for both and then remove them again for one
  of them while for the package where you want them, there's no
  difference in speed.

* Reduces complexity.

* More predictable.

What likely triggered the commit 979b6fb16609f871487d5d77f23731e2d4b7d23d:

* grub-common recommends os-prober, but os-prober is neither needed
  nor wanted in a freshly bootstrapped virtual machine.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)