[xen-tools-discuss] installDebianPackage + --no-install-recommends == subtle issues (w/ custom roles)

[Eric Engstrom]

All,

I'm sure there was some good thought behind the commit so that
recommended packages are no longer installed by installDebianPackage()
in hooks/common.sh. (see details below)

However, it took me a good while to realize this was the reason my
custom role file was not installing all the packages I expected.

Specifically in my case, I noted this first with the debian package
`logcheck`, which recommends `logcheck-database`, but I really expected
and wanted the latter too.  Of course, my workaround for now is to
_explicitly_ install some recommended packages like that.  I haven't yet
gone through all my custom role installed packages, but I'm sure I'll
find at least one more place where I want the recommended packages.

Anyone care to expand on the reasons for the change?

Thanks
Eric

FWIW: additional details:

$ git log --grep 'installDebian.*recommends'
commit 979b6fb16609f871487d5d77f23731e2d4b7d23d
Author: Axel Beckert <abe at deuxchevaux.org>
Date:   Tue Jan 22 21:45:57 2013 +0100
    hooks/common.sh: installDebianPackage no more installs recommends

$ git diff 57c7d13c488a47f4d468a0cc575fbbb27a275ade common.sh
diff --git a/hooks/common.sh b/hooks/common.sh
index 59c587f..3a5b814 100755
--- a/hooks/common.sh
+++ b/hooks/common.sh
@@ -98,7 +98,7 @@ installDebianPackage ()
     #
     # Install the packages
     #
-    DEBIAN_FRONTEND=noninteractive chroot ${prefix} /usr/bin/apt-get
--yes --force-yes install "$@"
+    DEBIAN_FRONTEND=noninteractive chroot ${prefix} /usr/bin/apt-get
--yes --force-yes --no-install-recommends install "$@"


-- 
Thanks,
Eric
--
Eric Engstrom  --  engstrom at SIFT.net
Smart Information Flow Technologies (SIFT)
211 N. 1st St. Suite 300, Minneapolis, MN 55401-1480