[xen-tools-discuss] Fix for bug #704878 breaks tests/deb build when lvm is set in config file.

[Axel Beckert]

Hi Adam,

On Wed, Oct 30, 2013 at 02:41:37PM -0700, Adam Wendt wrote:
> The fix for this:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704878 makes it so
> I can’t build a .deb on my server.
> 
> I have lvm=<something> in my /etc/xen-tools/xen-tools.conf

That explains why it doesn't happen for me. When building the package
in a clean chroot, xen-tools is not installed. I can also build it on
a machine with a virgin /etc/xen-tools/xen-tools.conf as shipped, but
I see that the test suite should be independent of any local xen-tools
installation.

> So when I run ‘prove t/xen-delete-image.t’ I get:
> $ prove t/xen-delete-image.t  
> t/xen-delete-image.t .. 1/?  
> # Failed test 'Calling xen-delete-image returned exit code 0'
> # at t/xen-delete-image.t line 79.
> 
> I printed out $CONFIG{‘lvm’} to verify that this was the cause:
> 
> not ok 6 - Calling xen-delete-image returned exit code 0
> Error: --test only works with --dir LVM: vg1.

This fix is definitely suboptimal.

> I can’t think of any solutions off the top of my head that solve
> this for all use cases, thoughts?

Will have to think about that, too. Thanks for notice!

On Wed, Oct 30, 2013 at 02:46:08PM -0700, Adam Wendt wrote:
> I would be remiss if I didn’t point out that I’m doing this on
> squeeze, so I already had to mess with things a bit, changing
> debian/compat to 8 and running dpkg-buildpackage with -d.

There is a 9.something version of debhelper in squeeze-backports:
http://packages.debian.org/squeeze-backports/debhelper

That one should suffice to fulfill any debhelper build-dependency out
there currently.

> Though I don’t see any reason this would make a difference.

Using 9 is mostly a convenience to get rid of the dh_python being
deprecated warning:

* dh does not default to enabling --with=python-support

Another debhelper v9 feature I tend to use (but don't use yet in
xen-tools) is this:

* Executable debhelper config files are run and their output used as
  the configuration.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)