[xen-tools-dev] xen-create-image: allow xvc0 in --serial_device option.

[Jorge Armando Medina]

Hi there,

I just downloaded xen-tools 4.2 from git, and reading about the new
option --serial_device I found the follow:

1. hvc0 is the default hardcoded in /usr/bin/xen-create-image, I think
it is better to default it in xen-tools.conf.

2-.  when using xen-create-image .... --serial_device=xvc0 I get a
mmessage about invalid option, reading the code I found this validation:


        serialDev => {
            check   => qr/^(?:\/dev\/)?(?:tty|hvc)[0-9]+$/,
            message => "must be a serial device (tty*, hvc*).\n",
        },

I change it to

        serialDev => {
            check   => qr/^(?:\/dev\/)?(?:tty|[xh]vc)[0-9]+$/,
            message => "must be a serial device (tty*, hvc* or xvc*).\n",
        },


I attach a simple patch for xen-create-image.

Another note, probably would be good to have this same validation for
xen-tools.conf, because it accepts what ever value you use.

Best regards and I hope you can include this simple fix because xvc0 is
used in a few hooks.

-- 
Jorge Armando Medina
Computación Gráfica de México
Web: http://www.e-compugraf.com
Tel: 55 51 40 72, Ext: 124
Email: jmedina at e-compugraf.com
GPG Key: 1024D/28E40632 2007-07-26
GPG Fingerprint: 59E2 0C7C F128 B550 B3A6  D3AF C574 8422 28E4 0632

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xen-create-image-allow-xvc0-in-serial_device.patch
Type: text/x-diff
Size: 607 bytes
Desc: not available
URL: <http://xen-tools.org/pipermail/xen-tools-dev/attachments/20100920/3533fcfc/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://xen-tools.org/pipermail/xen-tools-dev/attachments/20100920/3533fcfc/attachment.pgp>