[xen-tools-dev] xen-create-image: allow xvc0 in --serial_device option.

[Dmitry Nedospasov]

Hello Jorge,

On Mon, Sep 20, 2010 at 11:43:36AM -0500, Jorge Armando Medina wrote:
> Hi there,
> 1. hvc0 is the default hardcoded in /usr/bin/xen-create-image, I think
> it is better to default it in xen-tools.conf.

The reason for this is actually that hvc0 is the recommended setting for
xen, and it should be the default for all "newer" domUs. Xen
unfortunately used several "default" serial devices before ariving at
today's hvc0.

> I change it to
> 
>         serialDev => {
>             check   => qr/^(?:\/dev\/)?(?:tty|[xh]vc)[0-9]+$/,
>             message => "must be a serial device (tty*, hvc* or xvc*).\n",
>         },

Looks simple enough.

> Another note, probably would be good to have this same validation for
> xen-tools.conf, because it accepts what ever value you use.

Will have to investigate, but this is an interesting point that i forgot
to test :P AFAIK the options will still get parsed and checked though.

> Best regards and I hope you can include this simple fix because xvc0 is
> used in a few hooks.

Okay agreed, though I'm not entirely sure that we shouldn't just use
hvc0 and remove xvc0 from the scripts. If you have legacy vms that you
are importing, it is still possible to set them via .cfg file. Again,
new machines *SHOULD NOT* use anything other than hvc0 acording to the
xen documentation.

Thanks,

D.
-- 
Dmitry Nedospasov <dmitry at nedos.net> -- Twitter: @nedos
Web: http://nedos.net -- Github: http://github.com/nedos