[xen-tools-dev] xen-create-image: allow xvc0 in --serial_device option.

[Stéphane Jourdois]

Le 20/09/2010 19:23, Dmitry Nedospasov a écrit :
> Hello Jorge,

Hi everybody,


> On Mon, Sep 20, 2010 at 11:43:36AM -0500, Jorge Armando Medina wrote:
>> I change it to
>>
>>          serialDev =>  {
>>              check   =>  qr/^(?:\/dev\/)?(?:tty|[xh]vc)[0-9]+$/,
>>              message =>  "must be a serial device (tty*, hvc* or xvc*).\n",
>>          },
>
> Looks simple enough.

ACK.

While looking into the existing code, I found a bug a few lines after 
this test : tty and hvc are not valid for disk devices. I'll push a 
patch into the repository tomorrow to fix this one.


>> Another note, probably would be good to have this same validation for
>> xen-tools.conf, because it accepts what ever value you use.
>
> Will have to investigate, but this is an interesting point that i forgot
> to test :P AFAIK the options will still get parsed and checked though.

That is true. I intend to refactor the validation code in a future release.


>> Best regards and I hope you can include this simple fix because xvc0 is
>> used in a few hooks.
>
> Okay agreed, though I'm not entirely sure that we shouldn't just use
> hvc0 and remove xvc0 from the scripts. If you have legacy vms that you
> are importing, it is still possible to set them via .cfg file. Again,
> new machines *SHOULD NOT* use anything other than hvc0 acording to the
> xen documentation.

Dmitry has a better knowledge than me of xen history, so I tend to agree 
with him.

Thanks.
Stephane.

-- 
  ///  Stephane Jourdois     /"\  ASCII RIBBON CAMPAIGN \\\
(((    Consultant securite  \ /    AGAINST HTML MAIL    )))
  \\\   157 Bd Davout         X                         ///
   \\\  75020  Paris         / \    +33 6 8643 3085    ///