[xen-tools-dev] xen-create-image: allow xvc0 in --serial_device option.

[Axel Beckert]

Hi,

On Mon, Sep 20, 2010 at 11:43:36AM -0500, Jorge Armando Medina wrote:
> I just downloaded xen-tools 4.2 from git, and reading about the new
> option --serial_device I found the follow:
> 
> 1. hvc0 is the default hardcoded in /usr/bin/xen-create-image, I think
> it is better to default it in xen-tools.conf.

Will have a look at it.

> 2-.  when using xen-create-image .... --serial_device=xvc0 I get a
> mmessage about invalid option, reading the code I found this validation:
> 
> 
>         serialDev => {
>             check   => qr/^(?:\/dev\/)?(?:tty|hvc)[0-9]+$/,
>             message => "must be a serial device (tty*, hvc*).\n",
>         },
> 
> I change it to
> 
>         serialDev => {
>             check   => qr/^(?:\/dev\/)?(?:tty|[xh]vc)[0-9]+$/,
>             message => "must be a serial device (tty*, hvc* or xvc*).\n",
>         },
> 
> 
> I attach a simple patch for xen-create-image.

Committed. Will appear online after my next push and will be included
in the 4.2 release. Thanks, was just in time for that. :-)

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)